Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
petervachon
force-pushed
the
dashboardTemplates_032026
branch
from
26a5f3d to
3fad1ee
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
petervachon
force-pushed
the
dashboardTemplates_032026
branch
from
9746028 to
95b563f
Compare
petervachon
requested review from
KokoMilev and
frankkluijtmans
and removed request for
a team
|
This PR has been stale for over 2 weeks with no new commits. Closing — feel free to reopen if you'd like to continue this work. To keep a PR exempt from this automation, add the |
|
I'd like to start reviewing this with the team. Please keep open |
|
This PR has been stale for over 2 weeks with no new commits. Closing — feel free to reopen if you'd like to continue this work. To keep a PR exempt from this automation, add the |
KokoMilev
left a comment
KokoMilev
left a comment
There was a problem hiding this comment.
I'm sorry, but I'm not able to give this PR the review it deserves in its current form.
At 4k+ lines across 30 files and 40+ commits, it's simply too large to review we should expect from code review.
Could we redo this as a series of stacked PRs? By that I mean breaking the work into a few smaller, focused PRs, where each one builds on the previous and contains a single logical layer of change. Looking at what's in this PR, a reasonable split could be:
- Foundation — registry & preview scaffolding, data layer, and the dashboard shell/template (
registry.json,_meta.ts,preview/*,DashboardDataProvider,dashboard-data,DashboardTemplate,DashboardShellWrapper,DashboardRoutes,DashboardContent,DashboardLoading) - Insights & prompt bar — the core feature surface (
InsightGrid,insight-card-renderers,DashboardCards,AutopilotInsight,ExpandedInsightContent,PromptBar) - Glow + dev controls + docs — visual polish, tooling, and documentation (
DashboardGlow,glow-config,GlowDevControls,dev-controls-*,layouts/dashboard/page.mdx)
This keeps each PR reviewable on its own, makes the intent of each layer clearer, and reduces the risk of something slipping through. Furthermore add description into each PR it saves a lot of time for the reviewer.
If it helps, here's a good overview of the approach: https://www.stacking.dev/
Same thing, at this size we can't properly review anymore. Also; be a bit more careful with commits. When you're going back in to fix some stuff in a previous commit, have the AI agent amend that commit instead of creating a new one called To address the current state of this PR, can you try to see if you can get an agent to split this up? |
|
Yes absolutely. I'm going through a similar process with a larger PR (AI Chat). Once I lock that down I'll break up this one and put together a new set of PRs |
5 participants
No description provided.